Changed the way maximum velocity is capped, fixing 2 importants bugs:#22
Open
winterismute wants to merge 1 commit intoFlixelCommunity:masterfrom
Open
Changed the way maximum velocity is capped, fixing 2 importants bugs:#22winterismute wants to merge 1 commit intoFlixelCommunity:masterfrom
winterismute wants to merge 1 commit intoFlixelCommunity:masterfrom
Conversation
- The check about max velocity in either directions now takes the ABS value of the current speed into account (before, negative speeds were not capped) - When both x and y velocity are nonzero, we cap both of them to maxVel * sqrt(3) / 2, which is mathematically correct and prevent characters moving diagonal to exceed the max speed (so they don't go faster when they move diagonally)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
value of the current speed into account (before, negative speeds were
not capped)
sqrt(3) / 2, which is mathematically correct and prevent characters
moving diagonal to exceed the max speed (so they don't go faster when
they move diagonally)